just merged this in case someone wants to use it... #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
may be race-y due to always storing latest in global. might want to use a map of some sort.
fixing interoperability with native child_process. also added tests
check the sigchld handler
fixing OSX build * soumith/master: fixing OSX build
Switch to new Streams API. * Gottox/newStreams: use Terminal.super_ instead of hard coded parent constructor. use new streams instead of old "data" API.
Merge pull request chjj#37 from niallo/waitpid Report status code of child process in `term.status` property * niallo/waitpid: missed test file adding travis node 0.10 compatibility set SA_NOCLDSTOP flag for SIGCHLD handler must set exit status correctly fixing interoperability with native child_process. also added tests call node/libuv's SIGCHLD handler. zap status property which krept in. demonstrate fetching exit status use a PID -> exit code map to avoid race conditions. save exit status of child via SIGCHLD handler and waitpid(3) may be race-y due to always storing latest in global. might want to use a map of some sort. Conflicts: lib/pty.js src/unix/pty.cc
50 tasks
|
Any update on getting this merged? |
Contributor
Author
|
I used this version a while ago, but I imagine it's out of date now. I suppose I could rebase it and fix it if there's interest.. |
Owner
|
I'm mostly interested in the SIGCHLD code. If we could get that into a separate PR, that would be good. |
|
That's the part I'm interested in getting in also. Would be great if we
|
Contributor
Author
|
so, what needs to be done then, exactly? (besides the rebase) thing is, I don't really have the time at this moment. perhaps next week? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#91 (OSX fixes) & #94 (new streams) & #37 (child status code) were all merged. though, I have not really tried this out extensively yet (this afternoon's task).
well, cheers